masaori335 commented on code in PR #12529:
URL: https://github.com/apache/trafficserver/pull/12529#discussion_r2374853900
##########
src/proxy/http/HttpSM.cc:
##########
@@ -869,15 +869,24 @@ HttpSM::state_watch_for_client_abort(int event, void
*data)
* client.
*/
case VC_EVENT_EOS: {
- // We got an early EOS. To trigger background fill, do NOT kill HttpSM.
+ // We got an early EOS.
if (!terminate_sm) { // Not done already
NetVConnection *netvc = _ua.get_txn()->get_netvc();
- if (netvc) {
- if (_ua.get_txn()->allow_half_open()) {
+ if (_ua.get_txn()->allow_half_open() ||
tunnel.has_consumer_besides_client()) {
+ if (netvc) {
netvc->do_io_shutdown(IO_SHUTDOWN_READ);
- } else {
- netvc->do_io_shutdown(IO_SHUTDOWN_READWRITE);
}
+ } else if (t_state.txn_conf->cache_http &&
+ (server_entry != nullptr && server_entry->vc_read_handler ==
&HttpSM::state_read_server_response_header)) {
Review Comment:
If we compare with 244d82a (the parent commit of #12502), adding this else
if block is the main change.
##########
src/proxy/http/HttpSM.cc:
##########
@@ -869,15 +869,24 @@ HttpSM::state_watch_for_client_abort(int event, void
*data)
* client.
*/
case VC_EVENT_EOS: {
- // We got an early EOS. To trigger background fill, do NOT kill HttpSM.
+ // We got an early EOS.
if (!terminate_sm) { // Not done already
NetVConnection *netvc = _ua.get_txn()->get_netvc();
- if (netvc) {
- if (_ua.get_txn()->allow_half_open()) {
+ if (_ua.get_txn()->allow_half_open() ||
tunnel.has_consumer_besides_client()) {
+ if (netvc) {
netvc->do_io_shutdown(IO_SHUTDOWN_READ);
- } else {
- netvc->do_io_shutdown(IO_SHUTDOWN_READWRITE);
}
+ } else if (t_state.txn_conf->cache_http &&
Review Comment:
If we compare with
https://github.com/apache/trafficserver/commit/244d82a061c41d9498514d6eb15a3db43d2489fa
(the parent commit of #12502), adding this `else if` block is the main change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
