maskit commented on code in PR #12531:
URL: https://github.com/apache/trafficserver/pull/12531#discussion_r2392896752
##########
src/proxy/http2/Http2ConnectionState.cc:
##########
@@ -1368,14 +1368,18 @@ Http2ConnectionState::send_connection_preface()
configured_settings.set(HTTP2_SETTINGS_MAX_CONCURRENT_STREAMS,
_adjust_concurrent_stream());
- uint32_t const configured_initial_window_size =
this->_get_configured_receive_session_window_size();
+ uint32_t configured_initial_window_size;
if (this->_has_dynamic_stream_window()) {
Review Comment:
Can't we just remove this condition, `_has_dynamic_stream_window`, instead?
It looks like `_get_configured_receive_session_window_size` is supposed to
return an appropriate value based on the policy. I wonder why we wanted to
modify `configured_settings` only if the policy is dynamic.
https://github.com/apache/trafficserver/blob/534475f5b4f6278bc8981ff7965ee382b0ccf644/src/proxy/http2/Http2ConnectionState.cc#L2894-L2921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
