maskit commented on PR #12554: URL: https://github.com/apache/trafficserver/pull/12554#issuecomment-3402372037
> Looks fine, approving as is. But would a debug log for the else case be helpful potentially? There's a debug log on the caller side, and that works for all address sources. > I would like to see the implementation being safer by doing null check on the input arguments and return TS_ERROR. I do not think that is a good idea. If we took that way, null check would be done again and again by all functions that receive vconn on every call. So redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
