ezelkow1 commented on code in PR #12594:
URL: https://github.com/apache/trafficserver/pull/12594#discussion_r2452689676
##########
plugins/experimental/maxmind_acl/mmdb.h:
##########
@@ -71,6 +66,20 @@ class Acl
if (db_loaded) {
MMDB_close(&_mmdb);
}
+ for (auto &i : allow_regex) {
+ for (auto &y : i.second) {
+ if (y._rex != nullptr) {
+ delete y._rex;
+ }
+ }
+ }
+ for (auto &i : deny_regex) {
+ for (auto &y : i.second) {
+ if (y._rex != nullptr) {
+ delete y._rex;
+ }
+ }
+ }
Review Comment:
I am also fine with just removing that loop in the regex parsing, so it
would basically just take the first entry as the country code and the last
entry as the regex, and skip any extra country codes that might exist. This is
how its documented to work, being able to do this sharing shouldnt even
technically be there anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
