bneradt commented on code in PR #12600:
URL: https://github.com/apache/trafficserver/pull/12600#discussion_r2453503820
##########
plugins/esi/esi.cc:
##########
@@ -837,8 +837,8 @@ transformData(TSCont contp)
CONT_DATA_DBG(cont_data, "[%s] trying to process doc", __FUNCTION__);
string out_data;
string cdata;
- int overall_len;
- EsiProcessor::ReturnCode retval = cont_data->esi_proc->flush(out_data,
overall_len);
+ int overall_len = 0;
Review Comment:
This variable was used uninitialized before later in this function. The
assumption was that `flush` would set the value to some value, always. Even in
error cases. Before this patch it wasn't. We now initialize the variable to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
