bryancall commented on code in PR #12613:
URL: https://github.com/apache/trafficserver/pull/12613#discussion_r2461655307
##########
include/tscore/ink_inet.h:
##########
@@ -323,9 +323,10 @@ inline void
ats_unix_append_id(sockaddr_un *s, int id)
{
char tmp[16];
- int cnt = snprintf(tmp, sizeof(tmp), "-%d", id);
- if (static_cast<size_t>(ats_unix_path_len(s) + cnt) < TS_UNIX_SIZE) {
- strncat(s->sun_path, tmp, cnt);
+ int cnt = snprintf(tmp, sizeof(tmp), "-%d", id);
Review Comment:
The size of tmp is over the size needed to convert an int to a string. The
format string and size of int are known, so I don't see how there would be an
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
