bneradt commented on code in PR #12614: URL: https://github.com/apache/trafficserver/pull/12614#discussion_r2461797249
########## plugins/experimental/uri_signing/unit_tests/uri_signing_test.cc: ########## Review Comment: Now that you're posting this fix, it makes me wonder whether nullptr is being handled properly at all by this helper function. If I understand correctly, if expected_strip is nullptr, the caller expects that paramName value to be empty. It doesn't look like this helper function verifies that but it should. Your fix doesn't make this worse, but while we're at it, it should be easy to fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
