Copilot commented on code in PR #12581:
URL: https://github.com/apache/trafficserver/pull/12581#discussion_r2467233117
##########
src/iocore/utils/OneWayMultiTunnel.cc:
##########
@@ -45,6 +44,18 @@ OneWayMultiTunnel::OneWayMultiTunnel() : OneWayTunnel()
ink_zero(vioTargets);
}
+VIO *
+vc_do_io_write(VConnection *vc, Continuation *cont, int64_t nbytes, MIOBuffer
*buf, int64_t offset)
+{
+ IOBufferReader *reader = buf->alloc_reader();
+
+ if (offset > 0) {
+ reader->consume(offset);
+ }
+
+ return vc->do_io_write(cont, nbytes, reader, true);
+}
Review Comment:
This function `vc_do_io_write` appears to be duplicated from the removed
`P_VConnection.h`. Consider whether this should be moved to a shared location
or if it's intentionally file-specific. The same implementation was in the
deleted header file, suggesting it might be used elsewhere.
##########
src/iocore/eventsystem/UnixEThread.cc:
##########
@@ -52,7 +54,8 @@ char const *const EThread::Metrics::Slice::STAT_NAME[] = {
"proxy.process.eventloop.io.wait.max", "proxy.process.eventloop.io.work.max",
};
-int thread_max_heartbeat_mseconds = THREAD_MAX_HEARTBEAT_MSECONDS;
+int thread_max_heartbeat_mseconds = THREAD_MAX_HEARTBEAT_MSECONDS;
+const ink_hrtime DELAY_FOR_RETRY = HRTIME_MSECONDS(10);
Review Comment:
The constant `DELAY_FOR_RETRY` is being defined here but was previously in
`P_UnixEThread.h`. If this constant is used in other translation units, this
change could cause linker errors due to multiple definitions, or undefined
references if those files haven't been updated to include the necessary
declaration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
