JosiahWI commented on code in PR #12618:
URL: https://github.com/apache/trafficserver/pull/12618#discussion_r2469843377
##########
src/iocore/cache/HttpTransactCache.cc:
##########
@@ -1244,7 +1244,11 @@ HttpTransactCache::CalcVariability(const
HttpConfigAccessor *http_config_params,
// Disable Vary mismatch checking for Accept-Encoding. This is only
safe to
// set if you are promising to fix any
Accept-Encoding/Content-Encoding mismatches.
- if (http_config_params->get_ignore_accept_encoding_mismatch() &&
+ // Only suppress variability checks when the operator explicitly set
+ // proxy.config.http.cache.ignore_accept_encoding_mismatch to 1. The
+ // documented default value of 2 should continue to enforce Vary header
+ // semantics whenever the origin sends one.
+ if ((http_config_params->get_ignore_accept_encoding_mismatch() == 1) &&
Review Comment:
This looks correct. Good fix. Sadly, I think this may not be covered by any
AuTests. (The AuTest adjusted in this PR has `ignore_accept_encoding_mismatch =
2`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
