bneradt commented on PR #12561: URL: https://github.com/apache/trafficserver/pull/12561#issuecomment-3457995640
> The issue is to avoid losing events for live objects. In this particular case this is fine. In the default case it looks like cont is null anyway. I guess if "this" had been deleted, would it cause a crash in this path? Since you've run with this a lot, we should probably go ahead with your fix. It isn't going to cause more object event loss since it was already passing null. Thank you @shinrich for the thoughts. I wasn't aware of the other pattern of passing this instead of nullptr when stopping a VC. That's important to keep in mind. After thinking about this some, I think I will move forward with this patch as is. We've had this in production now for a few weeks and it resolves the crash. So it's at least an improvement in that regard. And I think you're right that since the tunnel is torn down in this code, we probably don't want the HttpSM to handle timeout events from it later. I'm concerned it could inappropriately tear down the next tunnel created after the 100 Continue transaction is processed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
