bryancall commented on code in PR #12619:
URL: https://github.com/apache/trafficserver/pull/12619#discussion_r2470853367
##########
plugins/experimental/maxmind_acl/mmdb.cc:
##########
@@ -793,15 +786,15 @@ Acl::eval_country(MMDB_entry_data_s *entry_data, const
std::string &url)
Dbg(dbg_ctl, "saw url not empty: %s, %ld", url.c_str(), url.length());
if (!allow_regex[output].empty()) {
for (auto &i : allow_regex[output]) {
- if (PCRE_ERROR_NOMATCH != pcre_exec(i._rex, i._extra, url.c_str(),
url.length(), 0, PCRE_NOTEMPTY, nullptr, 0)) {
Review Comment:
Not passing the RE_NOTEMPTY flag to the two exec() calls below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
