Copilot commented on code in PR #12310:
URL: https://github.com/apache/trafficserver/pull/12310#discussion_r2482166302
##########
tests/gold_tests/pluginTest/conf_remap/conf_remap.test.py:
##########
@@ -0,0 +1,72 @@
+'''
+Test conf_reamp plugin
Review Comment:
Corrected spelling of 'conf_reamp' to 'conf_remap'.
```suggestion
Test conf_remap plugin
```
##########
include/proxy/http/HttpConfig.h:
##########
@@ -699,6 +725,12 @@ struct OverridableHttpConfigParams {
// Host Resolution order
HostResData host_res_data;
+
+ // bitset to hold the status codes that will BE cached with negative caching
enabled
+ HttpStatusCodeList negative_caching_list;
+
+ // bitset to hold the status codes that will used by nagative revalidating
enabled
Review Comment:
Corrected spelling of 'nagative' to 'negative'.
```suggestion
// bitset to hold the status codes that will used by negative revalidating
enabled
```
##########
doc/admin-guide/files/records.yaml.en.rst:
##########
@@ -1905,6 +1906,8 @@ Negative Response Caching
A value of ``0`` disables serving stale content and a value of ``1``
enables keeping and serving stale content if revalidation fails.
.. ts:cv:: CONFIG proxy.config.http.negative_revalidating_lifetime INT 1800
+ :reloadable:
+ :overridable:
Review Comment:
The `negative_revalidating_lifetime` configuration is marked as
`:overridable:`, but it's not present in the list of new overridable
configurations added in this PR (only the `negative_revalidating_list` is
added). If this configuration was not made overridable in this PR, this marker
should be removed.
```suggestion
```
##########
tests/gold_tests/pluginTest/conf_remap/conf_remap.test.py:
##########
@@ -0,0 +1,72 @@
+'''
+Test conf_reamp plugin
+'''
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the # "License"); you may
not use this file except in compliance
Review Comment:
Line 8 contains a malformed comment with `#` appearing twice. The closing
parenthesis and opening quote should be on the next line. This should be split
into two lines: line 8 ending with `(the` and line 9 starting with `#
\"License\");`
```suggestion
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
