Copilot commented on code in PR #12639: URL: https://github.com/apache/trafficserver/pull/12639#discussion_r2495036465
########## src/iocore/cache/P_CacheDir.h: ########## @@ -39,6 +40,7 @@ struct CacheVC; class CacheEvacuateDocVC; // #define LOOP_CHECK_MODE 1 Review Comment: The `FREE_BUF_BETWEEN_CYCLES` preprocessor define is commented out but referenced in CacheDir.cc at line 986. This creates ambiguity about whether this feature is intended to be available. If this is experimental/future functionality, consider removing the usage in CacheDir.cc or documenting why it's disabled by default. ```suggestion // #define LOOP_CHECK_MODE 1 // The FREE_BUF_BETWEEN_CYCLES macro is currently disabled by default. // It is intended for experimental or future functionality related to buffer freeing between cycles. // If you wish to enable this feature, uncomment the following line. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
