bryancall commented on code in PR #12607:
URL: https://github.com/apache/trafficserver/pull/12607#discussion_r2500541952
##########
plugins/cachekey/pattern.cc:
##########
@@ -299,18 +270,11 @@ Pattern::replace(const String &subject, String &result)
int previous = 0;
for (int i = 0; i < _tokenCount; i++) {
- int replIndex = _tokens[i];
- int start = ovector[2 * replIndex];
- int length = ovector[2 * replIndex + 1] - ovector[2 * replIndex];
-
- /* Handle the case when no match / a group capture result in an empty
string */
- if (start < 0) {
- start = 0;
- length = 0;
- }
+ int replIndex = _tokens[i];
Review Comment:
this check is done above on [line
264](https://github.com/apache/trafficserver/pull/12607/files#diff-0f9197c7533c4751f2b03aaad1bc1ec792376a3cbf54914f97612928d921419dR264)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
