Copilot commented on code in PR #309:
URL:
https://github.com/apache/trafficserver-ingress-controller/pull/309#discussion_r2524181462
##########
pluginats/connect_redis.lua:
##########
@@ -104,7 +104,17 @@ function get_wildcard_domain(req_host)
return "*" .. string.sub (req_host, pos)
end
----------------------------------------------
+function cache_lookup()
+ local cache = ts.http.get_cache_lookup_url()
+
+ if (cache == nil or #cache == 0) then
+ ts.debug("Cache lookup is empty")
+ else
+ ts.debug("Cache lookup using the get cache lookup url " .. cache)
+ end
+
+end
Review Comment:
The new `cache_lookup()` function lacks a comment describing its purpose and
when it's invoked. Add a comment explaining that this is a hook callback for
the cache lookup complete event, which logs the cache URL being used. This
would help maintainers understand its role in the caching functionality.
##########
pluginats/connect_redis.lua:
##########
@@ -116,13 +126,24 @@ function do_global_read_request()
ts.debug("In 'not response: '", response)
return 0
end
-
+
-- We only care about host, path, and port#
local req_scheme = ts.client_request.get_url_scheme() or 'http'
local req_host = ts.client_request.get_url_host() or ''
local req_path = ts.client_request.get_uri() or ''
local req_port = ts.client_request.get_url_port() or ''
-
+
+ -- Checking the http version
+ local ver = ts.client_request.get_version()
+ ts.debug("Requested http version is: " .. ver)
+ if (ver == "1.1" and req_scheme == "http") then
+ ts.client_request.set_url_host(req_host)
+ ts.debug("Host for http version 1.1 is: " .. req_host)
+ end
+ -- ts.client_request.set_url_host(req_host)
Review Comment:
This commented-out line appears to be leftover debug code. Consider removing
it entirely to improve code clarity, as the functionality has been moved to the
conditional block above (lines 139-142).
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
