Copilot commented on code in PR #12675: URL: https://github.com/apache/trafficserver/pull/12675#discussion_r2542701720
########## src/proxy/http/remap/unit-tests/remap_test_dlopen_leak_suppression.txt: ########## @@ -23,4 +23,7 @@ # something nasty or ASAN is detecting a false-positive. # PluginDso::load leak:PluginDso::load -leak:call_init \ No newline at end of file +leak:call_init +# On Rocky Linux 8, ASAN reports leaks from the dynamic linker during dlopen +# These are false positives as we properly call dlclose for each dlopen +leak:ld-linux-x86-64.so Review Comment: The suppression pattern `leak:ld-linux-x86-64.so` is architecture-specific (x86-64) and may not work on other architectures like ARM64 or i386. Consider using a more portable pattern like `leak:ld-linux` or documenting that this suppression is x86-64 specific. If Rocky Linux 8 is only supported on x86-64 in CI, this may be acceptable. ```suggestion leak:ld-linux ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
