JosiahWI commented on code in PR #12690:
URL: https://github.com/apache/trafficserver/pull/12690#discussion_r2551556602
##########
plugins/experimental/ja4_fingerprint/test_ja4.cc:
##########
@@ -230,7 +230,16 @@ TEST_CASE("JA4")
"when we create a JA4 fingerprint, "
"then indices [8,9] thereof should contain \"aa\".")
{
+ // Suppress false positive -Wrestrict warning in GCC 12 when optimizing
+ // See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105329
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wrestrict"
+#endif
TLS_summary.ALPN = "a";
Review Comment:
Would assigning `'a'` instead of `"a"` silence the warning? That would be
cleaner; I did not know the string interface supported that until now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
