bneradt commented on code in PR #12696:
URL: https://github.com/apache/trafficserver/pull/12696#discussion_r2558545023
##########
CMakeLists.txt:
##########
@@ -806,10 +806,18 @@ add_custom_target(
VERBATIM
)
+add_custom_target(
+ whitespace-format
+ ${CMAKE_SOURCE_DIR}/tools/whitespace-format.sh
+ WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+ COMMENT "fixing whitespace issues (trailing whitespace, DOS line endings)"
+ VERBATIM
+)
+
# Add a format target that runs all the formatters.
add_custom_target(
format
- DEPENDS clang-format yapf cmake-format
+ DEPENDS clang-format yapf cmake-format whitespace-format
Review Comment:
This is interesting, albeit not something this patch will address. I never
have issues yapf, but I always develop in a container from CI that has the
tools (namely, python, pip, pipenv) that makes this work reliably.
I assume you have python issues? I don't know of a way to address python
formatting more reliably. It would be nice if we had a compiled binary we can
ship like we do with clang-format, but I think that's not available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
