bryancall opened a new pull request, #12721:
URL: https://github.com/apache/trafficserver/pull/12721

   Remove the check for parent_routing_enabled() in the 
SDK_API_HttpParentProxySet regression tests. This check has been broken since 
2019 when commit 6d1535b193a4 removed the 
proxy.config.http.parent_proxy_routing_enable configuration variable as 
redundant.
   
   The ParentEnable field in ParentSelectionPolicy is no longer set by any code 
(defaults to 0) and is not checked anywhere except this test. The test was 
waiting indefinitely for parent_routing_enabled() to return true, which would 
never happen in a default configuration.
   
   The test uses TSHttpTxnParentProxySet() to dynamically set a parent proxy 
via the API, which works regardless of whether parent routing is configured in 
parent.config. The check was unnecessary and caused the test to hang at 
regression level 3 (-R 3).
   
   This allows the SDK_API_HttpParentProxySet_Success and _Fail tests to 
complete successfully.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to