masaori335 commented on code in PR #12710:
URL: https://github.com/apache/trafficserver/pull/12710#discussion_r2587643886
##########
src/iocore/cache/CacheRead.cc:
##########
@@ -816,6 +818,15 @@ CacheVC::openReadStartEarliest(int /* event ATS_UNUSED */,
Event * /* e ATS_UNUS
dir_lookaside_probe(&key, stripe, &earliest_dir, nullptr)) {
dir = earliest_dir;
if ((ret = do_read_call(&key)) == EVENT_RETURN) {
+ if (this->handler ==
reinterpret_cast<ContinuationHandler>(&CacheVC::openReadStartEarliest)) {
+ is_recursive_call = true;
+ if (++recursive > 10) {
+ char tmpstring[CRYPTO_HEX_SIZE];
+ Error("Too many recursive call with %s", key.toHexStr(tmpstring));
Review Comment:
Done
##########
src/iocore/cache/CacheRead.cc:
##########
@@ -816,6 +818,15 @@ CacheVC::openReadStartEarliest(int /* event ATS_UNUSED */,
Event * /* e ATS_UNUS
dir_lookaside_probe(&key, stripe, &earliest_dir, nullptr)) {
dir = earliest_dir;
if ((ret = do_read_call(&key)) == EVENT_RETURN) {
+ if (this->handler ==
reinterpret_cast<ContinuationHandler>(&CacheVC::openReadStartEarliest)) {
+ is_recursive_call = true;
+ if (++recursive > 10) {
+ char tmpstring[CRYPTO_HEX_SIZE];
+ Error("Too many recursive call with %s", key.toHexStr(tmpstring));
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
