bneradt commented on code in PR #12731:
URL: https://github.com/apache/trafficserver/pull/12731#discussion_r2590417507
##########
src/proxy/hdrs/unit_tests/test_URL.cc:
##########
@@ -76,16 +80,9 @@ TEST_CASE("Validate Scheme", "[proxy][validscheme]")
{"example://", false}
};
- for (auto i : scheme_test_cases) {
- // it's pretty hard to debug with
- // CHECK(validate_scheme(i.text) == i.valid);
-
- std::string_view text = i.text;
- if (validate_scheme(text) != i.valid) {
- std::printf("Validation of scheme: \"%s\", expected %s, but not\n",
text.data(), (i.valid ? "true" : "false"));
- CHECK(false);
- }
- }
Review Comment:
Note that the workarounds like this aren't necessary anymore with the
CAPTURE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
