cmcfarlen commented on PR #12761: URL: https://github.com/apache/trafficserver/pull/12761#issuecomment-3661752954
After sleeping on this, I decided that I don't like that the meaning of remote address in NetVConnection is overloaded for proxy protocol. So, I reverted that and instead introduced `get_client_addr` and friends to return either the proxy protocol IP or the remote IP based on the config. This also provides the ability to implement the `rchi` log fields that was requested in #8544. Now the TSHttpTxnClientAddrGet calls the new `get_client_addr` and the remote address can still be acquired by `TSNetVConnRemoteAddrGet` without ambiguity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
