serrislew commented on PR #12669: URL: https://github.com/apache/trafficserver/pull/12669#issuecomment-3716159100
@zwoop I see your point. Since this is an extension of our existing configs, we have the flexibility to change the schema as we want. Though we want to keep improving and modernizing our configs, we should start with a good foundation that allows us to build features more smoothly. I still think our v0 should not add any new features, we can build on those with future remap versions. I also think that the domains node might still be good to have so it's clear exactly which domains are resolving to the virtualhost config. As we introduce other configs (i.e. sni.yaml domains), it might not be as clear to the user that it has to resolve across all the host selectors of each config node. We can add warnings if host selectors don't match the initial domain section. We can discuss this more later. Nonetheless, I think your concern is valid. I will look into YAML'fying the remap node but keeping the logic changes as minimal as possible, since the virtualhost schema already introduces a lot of new changes. Thank you for your feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
