cmcfarlen commented on code in PR #12803:
URL: https://github.com/apache/trafficserver/pull/12803#discussion_r2684143952
##########
src/iocore/net/UnixNetAccept.cc:
##########
@@ -480,13 +480,21 @@ NetAccept::acceptEvent(int event, void *ep)
if (lock.is_locked()) {
if (action_->cancelled) {
e->cancel();
+ Server *s = action_->server.exchange(nullptr, std::memory_order_acq_rel);
+ if (s != nullptr) {
+ s->close();
+ }
Review Comment:
This is repetitive and could be an issue if the repeated code needs to
change. I recommend adding a function to clear and close, or perhaps calling
cancel on the action is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
