bneradt commented on code in PR #12820:
URL: https://github.com/apache/trafficserver/pull/12820#discussion_r2699598582


##########
tools/hrw4u/tests/test_lsp.py:
##########
@@ -360,10 +360,11 @@ def shared_lsp_client():
 
 
 @pytest.mark.parametrize(
-    "section,prefix,should_allow", [
+    "section,prefix,should_allow",
+    [
         ("SEND_REQUEST", "outbound.req.", True),
-        ("REMAP", "outbound.req.", False),
-        ("SEND_REQUEST", "outbound.resp.", False),
+        ("REMAP", "outbound.req.", True),  # outbound.req. is available in 
REMAP
+        ("SEND_REQUEST", "outbound.resp.", True),  # outbound.resp. is 
available in SEND_REQUEST

Review Comment:
   Is this correct? `outbound.resp` is available in `SEND_REQUEST` hook? Maybe 
there's a reason for this, but SEND_REQUEST hook seems to early to interact 
with `outbound.resp`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to