bneradt commented on PR #12823: URL: https://github.com/apache/trafficserver/pull/12823#issuecomment-3787335662
> The new location looks better, but I'm wondering if this is the earliest possible point to increment the metric. I think H2 requests that have decoding errors (e.g. unrecognized pseudo headers, compression errors, etc) are still not counted. You're right that H2 HPACK decode errors occur before new_transaction() and won't be counted. This fix addresses HTTP-level early failures (remap redirects, header parse errors, early error responses) which was the primary concern — these are now counted correctly. H2/H3 frame-level decode failures are a different category. Counting those would require incrementing in the frame processing code before decode, which is more involved. I suggest doing this simple move change which relatively easily makes the current counting more accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
