maskit commented on code in PR #12834: URL: https://github.com/apache/trafficserver/pull/12834#discussion_r2734418014
########## include/tscore/ink_endian.h: ########## @@ -26,8 +26,10 @@ #include "tscore/ink_config.h" #ifdef HAVE_SYS_ENDIAN_H +#if !defined(darwin) Review Comment: Old versions of macOS didn't have be64toh and the other functions, but now those are defined on endian.h, and those cause errors due to duplication. I could add a check for the availability of those functions, but this small change is enough. We don't have this issue on newer codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
