maskit commented on code in PR #12790:
URL: https://github.com/apache/trafficserver/pull/12790#discussion_r2738177167
##########
plugins/experimental/ja4_fingerprint/plugin.cc:
##########
@@ -289,9 +288,10 @@ add_ciphers(JA4::TLSClientHelloSummary &summary,
TSClientHello ch)
void
add_extensions(JA4::TLSClientHelloSummary &summary, TSClientHello ch)
{
- if (ch->extensions != nullptr) {
- const uint8_t *ext = ch->extensions;
- size_t remaining = ch->extensions_len;
+ // For BoringSSL, we have direct access to the extensions buffer
Review Comment:
Can't `ch` have a function that returns an iterator for extension type IDs
so plugins don't need to deal with the difference?
```
for (auto ext_type : ch->get_extension_types()) {
summary.add_extension(ext_type);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
