bneradt commented on code in PR #12811:
URL: https://github.com/apache/trafficserver/pull/12811#discussion_r2738587189
##########
plugins/experimental/ja4_fingerprint/plugin.cc:
##########
@@ -334,12 +369,36 @@ handle_read_request_hdr(TSCont cont, TSEvent event, void
*edata)
return TS_SUCCESS;
}
+// Check if a header field exists in the request.
+static bool
+header_exists(TSMBuffer bufp, TSMLoc hdr_loc, char const *field, int field_len)
+{
+ TSMLoc loc = TSMimeHdrFieldFind(bufp, hdr_loc, field, field_len);
+ if (loc != TS_NULL_MLOC) {
+ TSHandleMLocRelease(bufp, hdr_loc, loc);
+ return true;
+ }
+ return false;
+}
+
void
append_JA4_headers(TSCont /* cont ATS_UNUSED */, TSHttpTxn txnp, std::string
const *fingerprint)
{
TSMBuffer bufp;
TSMLoc hdr_loc;
- if (TS_SUCCESS == TSHttpTxnClientReqGet(txnp, &bufp, &hdr_loc)) {
+ if (TS_SUCCESS != TSHttpTxnClientReqGet(txnp, &bufp, &hdr_loc)) {
Review Comment:
Yeah, I see your perspective. I think I'll stick with this though for the
sake of consistency since that's what the other checks for error do in this
plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
