Copilot commented on code in PR #12835: URL: https://github.com/apache/trafficserver/pull/12835#discussion_r2738681805
########## tests/fuzzing/oss-fuzz.sh: ########## @@ -63,6 +63,10 @@ cp /opt/h3-tools-boringssl/boringssl/lib/libssl.so $OUT/lib/ cp /opt/h3-tools-boringssl/boringssl/lib/libcrypto.so $OUT/lib/ cp /opt/h3-tools-boringssl/quiche/lib/libquiche.so $OUT/lib/ cp /opt/h3-tools-boringssl/quiche/lib/libquiche.so $OUT/lib/libquiche.so.0 + +ln -sf $OUT/lib/libswoc.so.1.5.15 libswoc.so.1 +ln -sf $OUT/lib/libswoc.so.1.5.15 libswoc.so Review Comment: The symlink targets are missing the destination directory. These commands will create symlinks in the current working directory (build/) rather than in $OUT/lib/ where they should be. The commands should be: `ln -sf $OUT/lib/libswoc.so.1.5.15 $OUT/lib/libswoc.so.1` and `ln -sf $OUT/lib/libswoc.so.1.5.15 $OUT/lib/libswoc.so`, or alternatively change to $OUT/lib/ before creating the symlinks. ```suggestion ln -sf $OUT/lib/libswoc.so.1.5.15 $OUT/lib/libswoc.so.1 ln -sf $OUT/lib/libswoc.so.1.5.15 $OUT/lib/libswoc.so ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
