bneradt commented on code in PR #12845: URL: https://github.com/apache/trafficserver/pull/12845#discussion_r2755385381
########## tests/gold_tests/cache/replay/cache-read-retry-exhausted.replay.yaml: ########## @@ -0,0 +1,235 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# This replay file tests cache_open_write_fail_action = 5 (READ_RETRY) +# with concurrent requests and slow origin responses. +# +# Scenario: +# - Multiple concurrent requests arrive for the same uncached URL +# - Request 1 gets write lock, connects to origin (slow, 3 second response) +# - Request 2-3 try to read, retry reads, eventually get read-while-writer access +# - All requests should succeed with 200 responses from read-while-writer +# - Only ONE origin connection should be made (request collapsing works) +# - System should NOT crash (validates stability with fail_action=5 enabled) +# +# Expected Behavior: +# 1. Request collapsing works correctly (all requests get first-origin response) +# 2. Read-while-writer functions properly +# 3. No crashes occur +# 4. Content is cached properly +# + +meta: + version: "1.0" + +autest: + dns: + name: 'dns-read-retry-exhausted' + description: 'Test cache_open_write_fail_action = 5 (READ_RETRY) with slow origin and concurrent requests to verify request collapsing and stability' + + server: + name: 'origin-read-retry-exhausted' + + client: + name: 'client-read-retry-exhausted' + + ats: + name: 'ts-read-retry-exhausted' + process_config: + enable_cache: true + + records_config: + proxy.config.diags.debug.enabled: 1 + proxy.config.diags.debug.tags: 'http|cache|http_cache|http_trans' + # Enable READ_RETRY mode + proxy.config.http.cache.open_write_fail_action: 5 + # Configure retry parameters to exhaust quickly + proxy.config.http.cache.max_open_write_retries: 1 + proxy.config.http.cache.max_open_write_retry_timeout: 0 + # Only 5 read retries @ 100ms = 500ms total (not enough for 10s origin) Review Comment: 10s origin? I think it's a 3s origin, right? ########## tests/gold_tests/cache/cache-read-retry-mode.test.py: ########## @@ -0,0 +1,33 @@ +''' +Test cache_open_write_fail_action = 5 (READ_RETRY mode) +''' +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +Test.Summary = ''' +Test cache_open_write_fail_action = 5 (READ_RETRY mode) to verify: +1. Basic read-while-writer behavior with fail_action=5 +2. READ_RETRY mode configuration is accepted and functional +3. System does not crash under write lock contention +4. Requests are served correctly when read retries are exhausted +''' + +Test.ContinueOnFail = True + +# Tests using Proxy Verifier replays (deterministic, CI-friendly) +# These validate basic READ_RETRY behavior without timing-sensitive parallel requests +Test.ATSReplayTest(replay_file="replay/cache-read-retry-basic.replay.yaml") +Test.ATSReplayTest(replay_file="replay/cache-read-retry-exhausted.replay.yaml") Review Comment: I'm not sure that these two tests test something fundamentally different. Nor tha the second is doing anything related to "exhausted". Maybe just use the second one since it is a bit more complex than the first and rename it to simply `cache-read-retry.replay.yaml`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
