ezelkow1 commented on PR #12852: URL: https://github.com/apache/trafficserver/pull/12852#issuecomment-3856054919
1) This is actually a bug fix, the current code is wrong for ALL write_fail_actions involving stale (including previous 2/3). Before it was actually reporting these as FRESH when they were in fact STALE. 2) Will implement, just instead of always destroying will do it conditionally so we can still get 304's on write lock fails. 3) Just a nice to have, could be done later 4) will just remove the server_error so it uses the default since it did not go upstream and served stale here 5) Sort of agree here too, thinking about just adding a boolean to the what_is_document_freshness instead to denote if it should skip these checks instead of faking it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
