bryancall commented on PR #12857: URL: https://github.com/apache/trafficserver/pull/12857#issuecomment-3867911503
## Review Feedback Response Addressed Copilot's comments in commit 20a8bafe4b. ### Fixed | # | Comment | Fix | |---|---------|-----| | 1 | HasLegacyTLSSupport connects to www.google.com:443, depends on external network | Replaced with `127.0.0.1:1` (localhost, closed port). "Connection refused" = TLSv1 available, "no protocols available" = blocked by crypto-policy. No network dependency. | | 2 | TimeoutExpired returns True (false positive) | Changed to return False -- timeout on localhost means something is wrong, not that TLSv1 works | | 3 | SkipUnless in tls_client_versions.test.py passes invalid reason string | Removed the string arg. SkipUnless only accepts Condition objects; the reason is already in the Condition definition. | | 4 | SkipUnless in tls_client_versions_minmax.test.py passes invalid reason string | Same fix as above | ### Not Fixed (with rationale) | # | Comment | Reason | |---|---------|--------| | 1 | Only probes TLSv1.0, not TLSv1.1 | Crypto-policies (Fedora DEFAULT, RHEL DEFAULT, etc.) always disable TLSv1.0 and TLSv1.1 together. Testing one is sufficient. Added docstring explaining this rationale. | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
