Copilot commented on code in PR #12849:
URL: https://github.com/apache/trafficserver/pull/12849#discussion_r2785046794


##########
plugins/lua/ts_lua_misc.cc:
##########
@@ -631,3 +646,54 @@ ts_lua_get_traffic_server_version(lua_State *L)
   lua_pushstring(L, s);
   return 1;
 }
+
+static int
+ts_lua_connection_limit_exempt_list_add(lua_State *L)
+{
+  size_t      len;
+  const char *ip_ranges;
+
+  ip_ranges = luaL_checklstring(L, 1, &len);

Review Comment:
   New Lua bindings for TSConnectionLimitExemptListAdd/Remove/Clear are 
introduced here, but there doesn't appear to be a corresponding gold test 
exercising these functions (e.g., success on valid ranges and failure on 
invalid input). Please add coverage under tests/gold_tests/pluginTest/lua to 
prevent regressions in the Lua API surface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to