bneradt commented on code in PR #12869:
URL: https://github.com/apache/trafficserver/pull/12869#discussion_r2790514072
##########
doc/admin-guide/configuration/hrw4u.en.rst:
##########
@@ -158,7 +176,7 @@ Syntax Free-form
Structured `if (...) { ... }`
Conditions `cond %{...}` Implicit in `if (...)`
Operators Raw text (`set-header`) Structured assignments or
statements
Grouping `GROUP` / `GROUP:END` Use `()` inside `if`
expressions
-Else branches `else` with indented ops `else { ... }` with full
block
+Else branches `else` with indented ops `elif { ... }` and `else {
... }` with full blocks
Review Comment:
Probably good to `elif () { ... }`, with the `()` as you did above to
indicate a condition should be present with `elif`. `else` is fine as is since
it doesn't take a condition.
##########
doc/admin-guide/configuration/hrw4u.en.rst:
##########
@@ -107,13 +107,31 @@ significant). For instance:
}
REMAP {
- if inbound.status == 403 || access("/etc/lock") {
+ if inbound.status == 403 {
inbound.req.X-Fail = "1";
+ } elif inbound.status == 404 {
+ inbound.req.X-NotFound = "1";
} else {
no-op();
}
}
+ READ_RESPONSE {
+ if inbound.status >= 400 {
Review Comment:
If you look at the `tools/hrw4u/grammar/hrw4u.g4`, `>=` is not actually
supported. Maybe we want to add this, but I don't think this will work as is.
@zwoop : thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
