bryancall commented on PR #12878:
URL: https://github.com/apache/trafficserver/pull/12878#issuecomment-3893890592

   Found one correctness issue in the new metric verification helper:
   
   `Testers.ContainsExpression(f'{metric_name} {expected_value}', ...)` can 
false-pass when the expected value is a prefix of the actual value (for example 
expected `1` also matches `10`).
   
   Would you mind switching this to an anchored regex match so the assertion is 
exact? Something like `^<metric_name>\\s+<expected_value>$` (with `metric_name` 
escaped) avoids prefix matches and makes the check robust.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to