bryancall commented on PR #12889: URL: https://github.com/apache/trafficserver/pull/12889#issuecomment-3910787183
@zwoop I dug into this. Here's where we stand: **Can we make Copilot reviews automated?** Yes, but it requires a GitHub **branch ruleset** (the newer rulesets, not the older branch protection rules). You configure it in Settings > Rules > Rulesets > "Automatically request Copilot code review". Options include re-reviewing on each push and reviewing drafts. **Problem:** `.asf.yaml` only supports the older `protected_branches` syntax - it has no support for the newer branch rulesets. So we'd need to file an **ASF INFRA Jira ticket** requesting they either: 1. Add the Copilot auto-review branch ruleset to the trafficserver repo, or 2. Add branch ruleset support to `.asf.yaml` (longer term) **Can we make Copilot reviews required/blocking?** No. Copilot always leaves "Comment" reviews, never "Approve" or "Request changes". This means Copilot reviews **cannot** satisfy branch protection required-approval rules and won't block merges. This is a GitHub limitation - no workaround currently. **TL;DR:** Automated = yes, via INFRA ticket. Required = no, GitHub doesn't support it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
