bneradt commented on PR #12679: URL: https://github.com/apache/trafficserver/pull/12679#issuecomment-3924662030
> > Hi @JakeChampion > > > @bneradt if you wanted to - you could run this patchset/branch against the tests in [cache-tests](https://github.com/http-tests/cache-tests) https://cache-tests.fyi/#cdn-cache-control and see how many ATS is now passing for ☺️ > > > > > > I ran the tests and no tests change. Note that this patch adds targeted cache control header support, which I don't think the cache-tests have tests for. > > But it's good to verify that no new tests fail at least. :) > > The section I linked too includes cdn-cache-control which I think is what you are also adding in this patch set, did those tests begin to pass? Oh, I see. Thank you for being patient with me and clarifying this @JakeChampion . This is a good observation/question. No, this patch as is doesn't change those because this patch doesn't change default behavior. If we made cdn-cache-control treated as a targeted cache control header by default, then this should flip those to green. I'm guessing we don't want to make such a modifying change in a minor release (10.2.0) though. But this is a good thing to discuss. Maybe we can make that change in 10.2? Or maybe add this feature with the default to not honor any targeted cache control headers in 10.2 but enable it by default in 11? @zwoop : I'll defer to your wisdom on this: should we treat cdn-cache-control as a targeted cache control header for ATS by default in both 10.2 and 11, or just in 11, or in neither? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
