bryancall opened a new pull request, #12902:
URL: https://github.com/apache/trafficserver/pull/12902

   * **Guard `engine.h` include** -- OpenSSL 3.5 (Fedora 43+) removed the 
deprecated engine API entirely, including the header. Wrap the include in 
`SSLUtils.cc` with `__has_include` so the build succeeds on systems without it. 
The `ENGINE_load_dynamic`, `ENGINE_get_default_RSA`, and 
`ENGINE_load_private_key` calls were already properly guarded by 
`HAVE_ENGINE_*` cmake checks.
   
   * **Fix `check_symbol_exists` header path** -- The three ENGINE symbol 
checks in `CMakeLists.txt` used `"include/openssl/engine.h"` while every other 
OpenSSL check uses `"openssl/engine.h"`. Removed the incorrect `include/` 
prefix for consistency.
   
   ### Testing
   
   * Clean build on Fedora 43 with OpenSSL 3.5.4 (no engine.h present) -- 
1267/1267 targets, zero errors
   * cmake correctly detects ENGINE symbols as unavailable and the 
`__has_include` guard skips the missing header at compile time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to