bneradt commented on code in PR #12763: URL: https://github.com/apache/trafficserver/pull/12763#discussion_r2836510405
########## include/iocore/net/TLSBasicSupport.h: ########## @@ -103,4 +105,6 @@ class TLSBasicSupport ink_hrtime _tls_handshake_begin_time = 0; ink_hrtime _tls_handshake_end_time = 0; + uint64_t _tls_handshake_bytes_in = 0; + uint64_t _tls_handshake_bytes_out = 0; Review Comment: These are cache variables that are lazy initialized, right? If that's right, let's make them mutable so that get_tls_handshake_bytes can be const. As a getter, that would make more sense to the caller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
