Copilot commented on code in PR #12932: URL: https://github.com/apache/trafficserver/pull/12932#discussion_r2870169773
########## tests/gold_tests/dns/replay/connect_attempts_rr_no_retry.replay.yaml: ########## @@ -0,0 +1,133 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# This replay file assumes that caching is enabled. +# + +meta: + version: "1.0" + +# Configuration section for autest integration +autest: + description: 'Verify connect attempts behavior - no retry' + + dns: + name: 'dns-no' + records: {"backend.example.com": ["0.0.0.1", "0.0.0.2"]} + + server: + name: 'server-no' + + client: + name: 'client-no' + + ats: + name: 'ts-no' + process_config: + enable_cache: false + + records_config: + proxy.config.diags.debug.enabled: 1 + proxy.config.diags.debug.tags: 'http|hostdb|dns' + proxy.config.http.connect_attempts_rr_retries: 0 + proxy.config.http.connect_attempts_max_retries: 0 + proxy.config.http.connect_attempts_max_retries_down_server: 0 + proxy.config.http.connect_attempts_timeout: 1 + proxy.config.http.down_server.cache_time: 5 + + remap_config: + - from: "http://example.com/"; + to: "http://backend.example.com:{SERVER_HTTP_PORT}/"; + + log_validation: + error_log: + gold_file: "gold/connect_attempts_rr_no_error_log.gold" + +sessions: +- transactions: + # try 0.0.0.1 + - client-request: + method: GET + url: /path/ + version: '1.1' + headers: + fields: + - [Host, example.com] + - [uuid, 1] + + # should not hit + server-response: + status: 200 + reason: OK + + proxy-response: + status: 502 + + # try 0.0.0.2 + - client-request: + method: GET + url: /path/ + version: '1.1' + headers: + fields: + - [Host, example.com] + - [uuid, 2] + + # should not hit + server-response: + status: 200 + reason: OK + + proxy-response: + status: 502 + + # request expected hit down_server cache and immidiately get 500 Review Comment: Spelling: "immidiately" should be "immediately" in this comment (and consider rewording to a full sentence for clarity). ```suggestion # This request is expected to hit the down_server cache and immediately receive a 500 response. ``` ########## tests/gold_tests/dns/replay/connect_attempts_rr_max_retries.replay.yaml: ########## @@ -0,0 +1,133 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# This replay file assumes that caching is enabled. Review Comment: The header comment says caching is enabled, but this replay config explicitly sets `process_config.enable_cache: false`. Please update or remove the comment so it matches the test configuration. ```suggestion # This replay file runs with ATS caching disabled. ``` ########## tests/gold_tests/autest-site/ats_replay.test.ext: ########## @@ -272,6 +290,13 @@ def ATSReplayTest(obj, replay_file: str): f'^{re.escape(metric_name)}\\s+{expected_value}$', f'{metric_name} should be {expected_value}') check_tr.StillRunningAfter = ts + # wait for error log + if log_validation != None and log_validation['error_log'] != None: + wait_for_log = obj.AddTestRun('Wait for logs of ' + ats_config.get('name', 'ts')) + wait_for_log.Processes.Default.Command = ( + os.path.join(obj.Variables.AtsTestToolsDir, 'condwait') + ' 60 1 -f ' + os.path.join(ts.Variables.LOGDIR, 'error.log')) + wait_for_log.Processes.Default.ReturnCode = 0 Review Comment: In `ATSReplayTest`, the guard `if log_validation != None and log_validation['error_log'] != None:` can raise a `KeyError` when `autest.ats.log_validation` exists but does not define `error_log` (e.g. many existing replay tests only use `traffic_out` / `diags_log`). Please switch to a safe lookup (e.g. `error_log_cfg = (log_validation or {}).get('error_log')`) and check that value instead. ########## tests/gold_tests/dns/replay/connect_attempts_rr_max_retries.replay.yaml: ########## @@ -0,0 +1,133 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# This replay file assumes that caching is enabled. +# + +meta: + version: "1.0" + +# Configuration section for autest integration +autest: + description: 'Verify connect attempts behavior - round robin' + + dns: + name: 'dns-rr' + records: {"backend.example.com": ["0.0.0.1", "0.0.0.2"]} + + server: + name: 'server-rr' + + client: + name: 'client-rr' + + ats: + name: 'ts-rr' + process_config: + enable_cache: false + + records_config: + proxy.config.diags.debug.enabled: 1 + proxy.config.diags.debug.tags: 'http|hostdb|dns' + proxy.config.http.connect_attempts_rr_retries: 0 + proxy.config.http.connect_attempts_max_retries: 2 + proxy.config.http.connect_attempts_max_retries_down_server: 0 + proxy.config.http.connect_attempts_timeout: 1 + proxy.config.http.down_server.cache_time: 5 + + remap_config: + - from: "http://example.com/"; + to: "http://backend.example.com:{SERVER_HTTP_PORT}/"; + + log_validation: + error_log: + gold_file: "gold/connect_attempts_rr_max_retries_error_log.gold" + +sessions: +- transactions: + # try 0.0.0.1 + - client-request: + method: GET + url: /path/ + version: '1.1' + headers: + fields: + - [Host, example.com] + - [uuid, 1] + + # should not hit + server-response: + status: 200 + reason: OK + + proxy-response: + status: 502 + + # try 0.0.0.2 + - client-request: + method: GET + url: /path/ + version: '1.1' + headers: + fields: + - [Host, example.com] + - [uuid, 2] + + # should not hit + server-response: + status: 200 + reason: OK + + proxy-response: + status: 502 + + # request expected hit down_server cache and immidiately get 500 Review Comment: Spelling: "immidiately" should be "immediately" in this comment (and consider rewording to a full sentence for clarity). ```suggestion # The request is expected to hit the down_server cache and immediately receive a 500 response. ``` ########## tests/gold_tests/dns/replay/connect_attempts_rr_no_retry.replay.yaml: ########## @@ -0,0 +1,133 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# This replay file assumes that caching is enabled. Review Comment: The header comment says caching is enabled, but this replay config explicitly sets `process_config.enable_cache: false`. Please update or remove the comment so it matches the test configuration. ```suggestion # This replay file runs with caching disabled. ``` ########## tests/gold_tests/dns/replay/connect_attempts_rr_retries.replay.yaml: ########## @@ -0,0 +1,169 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# This replay file assumes that caching is enabled. Review Comment: The header comment says caching is enabled, but this replay config explicitly sets `process_config.enable_cache: false`. Please update or remove the comment so it matches the test configuration. ```suggestion # This replay file assumes that caching is disabled. ``` ########## tests/gold_tests/dns/replay/connect_attempts_rr_retries.replay.yaml: ########## @@ -0,0 +1,169 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# +# This replay file assumes that caching is enabled. +# + +meta: + version: "1.0" + +# Configuration section for autest integration +autest: + description: 'Verify connect attempts behavior - round robin' + + dns: + name: 'dns-rrr' + records: {"backend.example.com": ["0.0.0.1", "0.0.0.2"]} + + server: + name: 'server-rrr' + + client: + name: 'client-rrr' + + ats: + name: 'ts-rrr' + process_config: + enable_cache: false + + records_config: + proxy.config.diags.debug.enabled: 1 + proxy.config.diags.debug.tags: 'http|hostdb|dns' + proxy.config.http.connect_attempts_rr_retries: 2 + proxy.config.http.connect_attempts_max_retries: 0 + proxy.config.http.connect_attempts_max_retries_down_server: 0 + proxy.config.http.connect_attempts_timeout: 1 + proxy.config.http.down_server.cache_time: 5 + + remap_config: + - from: "http://example.com/"; + to: "http://backend.example.com:{SERVER_HTTP_PORT}/"; + + log_validation: + error_log: + gold_file: "gold/connect_attempts_rr_retries_error_log.gold" + +sessions: +- transactions: + # try 0.0.0.1 + - client-request: + method: GET + url: /path/ + version: '1.1' + headers: + fields: + - [Host, example.com] + - [uuid, 1] + + # should not hit + server-response: + status: 200 + reason: OK + + proxy-response: + status: 502 + + # try 0.0.0.1 again + - client-request: + method: GET + url: /path/ + version: '1.1' + headers: + fields: + - [Host, example.com] + - [uuid, 2] + + # should not hit + server-response: + status: 200 + reason: OK + + proxy-response: + status: 502 + + # try 0.0.0.2 + - client-request: + method: GET + url: /path/ + version: '1.1' + headers: + fields: + - [Host, example.com] + - [uuid, 3] + + # should not hit + server-response: + status: 200 + reason: OK + + proxy-response: + status: 502 + + # try 0.0.0.2 again + - client-request: + method: GET + url: /path/ + version: '1.1' + headers: + fields: + - [Host, example.com] + - [uuid, 4] + + # should not hit + server-response: + status: 200 + reason: OK + + proxy-response: + status: 502 + + # request expected hit down_server cache and immidiately get 500 Review Comment: Spelling: "immidiately" should be "immediately" in this comment (and consider rewording to a full sentence for clarity). ```suggestion # The request is expected to hit the down_server cache and immediately receive a 500 response. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
