maskit commented on code in PR #12914:
URL: https://github.com/apache/trafficserver/pull/12914#discussion_r2875618246
##########
src/api/InkAPI.cc:
##########
@@ -9158,3 +9191,72 @@ TSLogAddrUnmarshal(char **buf, char *dest, int len)
return {-1, -1};
}
+
+bool
+TSClientHello::is_available() const
+{
+ return static_cast<bool>(*this);
+}
+
+uint16_t
+TSClientHello::get_version() const
+{
+ return static_cast<TLSSNISupport::ClientHello
*>(_client_hello)->getVersion();
+}
+
+const uint8_t *
+TSClientHello::get_cipher_suites() const
+{
+ return reinterpret_cast<const uint8_t
*>(static_cast<TLSSNISupport::ClientHello
*>(_client_hello)->getCipherSuites().data());
+}
+
+size_t
+TSClientHello::get_cipher_suites_len() const
+{
+ return static_cast<TLSSNISupport::ClientHello
*>(_client_hello)->getCipherSuites().length();
+}
+
+TSClientHello::TSExtensionTypeList::Iterator::Iterator(const void *ite)
+{
+ static_assert(sizeof(_real_iterator) >=
sizeof(TLSSNISupport::ClientHello::ExtensionIdIterator));
+
+ ink_assert(_real_iterator);
+ ink_assert(ite);
+ memcpy(_real_iterator, ite,
sizeof(TLSSNISupport::ClientHello::ExtensionIdIterator));
+}
+
+TSClientHello::TSExtensionTypeList::Iterator
+TSClientHello::TSExtensionTypeList::begin()
+{
+ ink_assert(_ch);
+ auto ch = static_cast<TLSSNISupport::ClientHello *>(_ch);
+ auto ite = ch->begin();
+ // The temporal pointer is for the memcpy in the constructor. It's only used
in the constructor.
+ return TSClientHello::TSExtensionTypeList::Iterator(&ite);
+}
+
+TSClientHello::TSExtensionTypeList::Iterator
+TSClientHello::TSExtensionTypeList::end()
+{
+ auto ite = static_cast<TLSSNISupport::ClientHello *>(_ch)->end();
+ // The temporal pointer is for the memcpy in the constructor. It's only used
in the constructor.
+ return TSClientHello::TSExtensionTypeList::Iterator(&ite);
+}
+
+TSClientHello::TSExtensionTypeList::Iterator &
+TSClientHello::TSExtensionTypeList::Iterator::operator++()
+{
+ ++(*reinterpret_cast<TLSSNISupport::ClientHello::ExtensionIdIterator
*>(_real_iterator));
+ return *this;
+}
Review Comment:
The data won't be copied to a different arch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
