bryancall opened a new pull request, #12959: URL: https://github.com/apache/trafficserver/pull/12959
## Summary - Widen assertion in `HttpSM::tunnel_handler` to accept `VC_EVENT_ACTIVE_TIMEOUT`, `VC_EVENT_ERROR`, and `VC_EVENT_EOS` - These events can be dispatched to `tunnel_handler` via the server entry's VC handlers set after response header parsing, but the assertion only allowed `HTTP_TUNNEL_EVENT_DONE` and `VC_EVENT_INACTIVITY_TIMEOUT` - Every other VC handler in HttpSM properly handles these events; this was the only one missing them ## Background Observed as a fatal crash on `controller.trafficserver.org` (ATS 10.2.0, ASAN build) through an HTTP/2 code path: ``` Fatal: HttpSM.cc:3083: failed assertion `event == HTTP_TUNNEL_EVENT_DONE || event == VC_EVENT_INACTIVITY_TIMEOUT` HttpSM::tunnel_handler HttpSM::main_handler Continuation::handleEvent Http2Stream::main_event_handler ``` The handler already sets `terminate_sm = true` for all events it processes, so the fix is simply widening the assertion — the behavior for these additional events is the same (terminate the state machine). Fixes #12958 ## Test plan - [ ] Verify existing CI tests pass - [ ] Confirm the assertion no longer fires under HTTP/2 timeout/error conditions 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
