bneradt commented on code in PR #12950:
URL: https://github.com/apache/trafficserver/pull/12950#discussion_r2927565591
##########
doc/admin-guide/configuration/hrw4u.en.rst:
##########
@@ -434,10 +434,58 @@ Groups
...
}
+Control Flow
+------------
+
+HRW4U conditionals use ``if``, ``elif``, and ``else`` blocks. Each branch
+takes a condition expression followed by a ``{ ... }`` body of statements:
+
+.. code-block:: none
+
+ if condition {
+ statement;
+ } elif other-condition {
+ statement;
+ } else {
+ statement;
+ }
+
+``elif`` and ``else`` are optional and can be chained. Branches can be nested
+to arbitrary depth:
+
+.. code-block:: none
+
+ REMAP {
+ if inbound.status > 399 {
+ if inbound.status < 500 {
+ if inbound.status == 404 {
+ inbound.resp.X-Error = "not-found";
+ } elif inbound.status == 403 {
+ inbound.resp.X-Error = "forbidden";
+ }
+ } else {
+ inbound.resp.X-Error = "server-error";
+ }
+ }
+ }
+
+The ``break;`` statement exits the current section immediately, skipping any
+remaining statements and branches:
+
+.. code-block:: none
+
+ REMAP {
+ if inbound.req.X-Internal != "1" {
+ break;
+ }
+ # Only reached for internal requests
+ inbound.req.X-Debug = "on";
+ }
Review Comment:
"return;" be a more idiomatic keyword for this behavior. "break" is
typically for switch/loops.
Having said that, I don't think that "break" new to this PR. Just documented
here, if I'm understanding this correctly. If so, we can obviously address this
in a separte PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
