yknoya commented on code in PR #12936:
URL: https://github.com/apache/trafficserver/pull/12936#discussion_r2928216754
##########
src/proxy/http2/Http2ConnectionState.cc:
##########
@@ -477,13 +498,19 @@ Http2ConnectionState::rcv_headers_frame(const Http2Frame
&frame)
Http2ErrorCode result =
stream->decode_header_blocks(*this->local_hpack_handle,
this->acknowledged_local_settings.get(HTTP2_SETTINGS_HEADER_TABLE_SIZE));
- // If this was an outbound connection and the state was already closed,
just clear the
- // headers after processing. We just processed the heaer blocks to keep
the dynamic table in
+ // We just processed the heaer blocks to keep the dynamic table in
Review Comment:
Fixed in the following commit:
https://github.com/apache/trafficserver/pull/12936/commits/d98f026c077981ffce20386f2098bf1970b239cd
##########
src/proxy/http2/Http2ConnectionState.cc:
##########
@@ -1100,6 +1127,27 @@ Http2ConnectionState::rcv_continuation_frame(const
Http2Frame &frame)
Http2ErrorCode result =
stream->decode_header_blocks(*this->local_hpack_handle,
this->acknowledged_local_settings.get(HTTP2_SETTINGS_HEADER_TABLE_SIZE));
+ // We just processed the heaer blocks to keep the dynamic table in
Review Comment:
Fixed in the following commit:
https://github.com/apache/trafficserver/pull/12936/commits/d98f026c077981ffce20386f2098bf1970b239cd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
