Copilot commented on code in PR #12977: URL: https://github.com/apache/trafficserver/pull/12977#discussion_r2942882711
########## plugins/header_rewrite/operators.h: ########## @@ -487,8 +487,8 @@ class OperatorSetPluginCntl : public Operator } private: - PluginCtrl _name; - int _value; + PluginCtrl _name = PluginCtrl::TIMEZONE; + int _value = 0; Review Comment: `OperatorSetPluginCntl::initialize()` (operators.cc:1211+) has no `else`/error path for an unknown control name. With `_name`/`_value` now default-initialized (TIMEZONE/0), a config typo will silently apply TIMEZONE=LOCAL rather than failing fast. Consider adding an explicit INVALID enum value (or a boolean) set during `initialize()`, log a `TSError` for unknown names, and have `exec()` no-op/return false when invalid so misconfigurations don’t change transaction state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
