Copilot commented on code in PR #12976:
URL: https://github.com/apache/trafficserver/pull/12976#discussion_r2942892190
##########
include/proxy/FetchSM.h:
##########
@@ -165,7 +165,7 @@ class FetchSM : public Continuation
HTTPParser http_parser;
HTTPHdr client_response_hdr;
ChunkedHandler chunked_handler;
- TSFetchEvent callback_events;
+ TSFetchEvent callback_events{}; // TODO: ATS 11 - add default member
initializers to TSFetchEvent in apidefs.h (C API)
Review Comment:
The TODO here suggests adding C++ default member initializers to
`TSFetchEvent` in the C API header (`include/ts/apidefs.h.in` → generated
`apidefs.h`), which would break C compilation unless guarded by `#ifdef
__cplusplus`. Consider rewording/removing the TODO (e.g., just note that this
value-initializes a C struct), and wrap/shorten it to keep within the repo’s
132-character line limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
