moonchen commented on PR #12940:
URL: https://github.com/apache/trafficserver/pull/12940#issuecomment-4070818566
> The retry logic looks good overall, but there's an exit code ambiguity
that should be fixed:
>
> `_count_threads_once()` returns code 1 when `p.threads()` fails ("Could
not inspect ATS process threads"), but `count_threads()` treats code 1 as a
retryable "process not found yet" condition in `retry_codes = {1, 4, 6, 9,
11}`. This means a real permission/psutil error gets silently retried for the
full 10s window instead of failing immediately.
>
> Please use a distinct exit code (e.g. 12) for the `p.threads()` failure
case so it's not masked by the retry loop.
I've added a distinct exit code 12 for the condition when psutil gets an
access denied, so the test fails immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
