bneradt commented on code in PR #12957:
URL: https://github.com/apache/trafficserver/pull/12957#discussion_r2956491760
##########
tools/hrw4u/Makefile:
##########
@@ -169,6 +169,14 @@ $(PKG_DIR_LSP)/%: src/%
test:
uv run pytest --tb=short tests
+coverage:
+ uv run pytest --cov --cov-report=term-missing --cov-report=html tests
+ @echo ""
+ @echo "HTML report: open htmlcov/index.html"
Review Comment:
I hit an issue with the new coverage workflow on a clean checkout: `make
coverage` fails before pytest starts because the package is still installed
from `build/`, but that directory does not exist until the generated sources
have been created.
In my repro, `make coverage` failed with:
error in 'egg_base' option: 'build' does not exist or is not a directory
After generating the sources first, the suite passed.
Could we make `coverage` ensure `build/` exists first (for example by
depending on `gen`, or otherwise preparing the generated package layout), so
the documented workflow works from a fresh checkout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
