bneradt commented on code in PR #12988: URL: https://github.com/apache/trafficserver/pull/12988#discussion_r2962320118
########## src/proxy/ReverseProxy.cc: ########## @@ -214,14 +243,7 @@ init_remap_volume_host_records() table->acquire(); - Dbg(dbg_ctl_url_rewrite, "Initializing volume_host_rec for all remap rules after cache init"); - - // Initialize for all mapping stores - init_store_volume_host_records(table->forward_mappings); - init_store_volume_host_records(table->reverse_mappings); - init_store_volume_host_records(table->permanent_redirects); - init_store_volume_host_records(table->temporary_redirects); - init_store_volume_host_records(table->forward_mappings_with_recv_port); + init_table_volume_host_records(*table); Review Comment: Makes sense. I added the same is_valid() guard here so the post-cache-init path matches the earlier startup path. I don’t expect rewrite_table to normally hold an invalid table at this point, but guarding it here is clearer and more defensive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
